Skip to content

Add empty state for value map/relation #4132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaustuvpokharel wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add empty state for value map/relation #4132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
78c6db0
WIP: Diagnosing the space probkem with the empty delegate state compo…
kaustuvpokharel Oct 6, 2025
f18661a
changed coomponent to text
kaustuvpokharel Oct 7, 2025
446fcf4
fixed the position of -no items- text
kaustuvpokharel Oct 8, 2025
09b0c8f
suggested changes
kaustuvpokharel Oct 10, 2025
0eff715
fixed drawerBottomMargin
kaustuvpokharel Oct 10, 2025
4272b20
Added message if the value map is empty
gabriel-bolbotina Dec 5, 2025
cea5413
Implemented code review findings
gabriel-bolbotina Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/qml/components/MMListMultiselectDrawer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ MMDrawer {

interactive: !listViewComponent.interactive

drawerBottomMargin: 0
drawerBottomMargin: listViewComponent.count === 0
? (__style.margin20 + __style.safeAreaBottom)
: 0

drawerContent: Item {
width: parent.width
Expand Down Expand Up @@ -70,7 +72,6 @@ MMDrawer {
MMScrollView {
width: parent.width
height: Math.min( contentHeight, root.drawerContentAvailableHeight - internal.searchBarVerticalSpace )

enabled: contentHeight > height

Loader {
Expand All @@ -87,7 +88,7 @@ MMDrawer {

width: parent.width
height: Math.min( contentHeight, root.drawerContentAvailableHeight - internal.searchBarVerticalSpace )

visible: count > 0
interactive: contentHeight > height

clip: true
Expand Down
11 changes: 11 additions & 0 deletions app/qml/form/editors/MMFormValueMapEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,17 @@ MMFormComboboxBaseEditor {

drawerHeader.title: root._fieldTitle

emptyStateDelegate: Item {
width: parent.width
height: noItemsText.implicitHeight + __style.margin40

MMComponents.MMText {
id: noItemsText
text: qsTr( "No items" )
anchors.centerIn: parent
}
}

list.model: listModel

selected: root.preselectedItems
Expand Down
12 changes: 11 additions & 1 deletion app/qml/form/editors/MMFormValueRelationEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,19 @@ MMFormComboboxBaseEditor {
dropdownLoader.sourceComponent: Component {

MMComponents.MMListMultiselectDrawer {

drawerHeader.title: root._fieldTitle

emptyStateDelegate: Item {
width: parent.width
height: noItemsText.implicitHeight + __style.margin40

MMComponents.MMText {
id: noItemsText
text: qsTr( "No items" )
anchors.centerIn: parent
}
}

multiSelect: internal.allowMultivalue
withSearch: vrModel.count > 5
showFullScreen: multiSelect || withSearch
Expand Down
Loading