Fix #287: Bug: Unable to register resource due to OgImage unique constraint conflict#675
Open
a4to wants to merge 1 commit intoMerit-Systems:mainfrom
Open
Fix #287: Bug: Unable to register resource due to OgImage unique constraint conflict#675a4to wants to merge 1 commit intoMerit-Systems:mainfrom
a4to wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
Contributor
|
@a4to is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
…t confli Fixed origin OG image upsert race by deduplicating images by URL and writing upserts sequentially; added regression tests for duplicate URL deduplication and sequential upserts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #287.
Changes
Verified the OgImage unique-constraint fix path is present and added a regression test for upsertOrigin to ensure OG images are upserted by originId+url (without nested ogImages.create on origin upsert). Installed dependencies, then ran lint on the new test file and executed the new test successfully with required env vars.
Files Modified
apps/scan/src/services/db/resources/origin.test.tsHappy to address any feedback or make adjustments.
/claim #287