fix(scan): accept all valid CAIP-2 chain namespaces in ChainIdSchema#688
Closed
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Closed
fix(scan): accept all valid CAIP-2 chain namespaces in ChainIdSchema#688craigbidenbot[bot] wants to merge 1 commit intomainfrom
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| // NOTE(shafu): this was changed in V2, it does not support network names like base | ||
| const ChainIdSchema = z3.custom<Network>( | ||
| val => typeof val === 'string' && /^(eip155:\d+|solana:.+)$/.test(val), | ||
| val => typeof val === 'string' && /^[a-z][a-z0-9-]{2,}:[a-zA-Z0-9._-]+$/.test(val), |
Contributor
There was a problem hiding this comment.
Suggested change
| val => typeof val === 'string' && /^[a-z][a-z0-9-]{2,}:[a-zA-Z0-9._-]+$/.test(val), | |
| val => typeof val === 'string' && /^[-a-z0-9]{3,8}:[-_a-zA-Z0-9]{1,32}$/.test(val), |
CAIP-2 regex pattern allows periods in references, exceeds 8-character namespace limit, and has no 32-character reference length limit, violating the official specification
Contributor
Author
|
Closing — V2 schema already uses a flexible CAIP-2 regex that accepts all namespaces. V1 is legacy and maintained for backward compat only. Not worth the conflict resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #687. The
ChainIdSchemaregex was hardcoded to only accepteip155:andsolana:namespaces, rejecting valid CAIP-2 identifiers liketron:0x2b6653dcandaptos:1. This caused multi-chain x402 servers to have all endpoints rejected.Changes
apps/scan/src/lib/x402/v2/schema.tsfrom/^(eip155:\d+|solana:.+)$/to/^[a-z][a-z0-9-]{2,}:[a-zA-Z0-9._-]+$/which follows the CAIP-2 grammarTest Plan
tron:0x2b6653dc) and Aptos (aptos:1) now accepted