Skip to content

Adding initial Met Office configuration for VerPy database and plotti…#2134

Open
RachelNorth wants to merge 1 commit into
mainfrom
2133-adding-new-verpy-capability-for-using-at-uk-met-office
Open

Adding initial Met Office configuration for VerPy database and plotti…#2134
RachelNorth wants to merge 1 commit into
mainfrom
2133-adding-new-verpy-capability-for-using-at-uk-met-office

Conversation

@RachelNorth
Copy link
Copy Markdown
Contributor

@RachelNorth RachelNorth commented May 15, 2026

…ng capability

Adds configuration and modifications needed to run the VerPy database creation and plotting (of METplus verification results) at the Met Office. As part of #2133.

Contribution checklist

Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.

  • Documentation has been updated to reflect change.
  • New code has tests, and affected old tests have been updated.
  • All tests and CI checks pass.
  • Ensured the pull request title is descriptive.
  • Ensure rose-suite.conf.example has been updated if new diagnostic added.
  • Conda lock files have been updated if dependencies have changed.
  • Attributed any Generative AI, such as GitHub Copilot, used in this PR.
  • Marked the PR as ready to review.

@github-actions
Copy link
Copy Markdown
Contributor

Coverage

@mo-tomosevans
Copy link
Copy Markdown

Hi, having pulled this PR for testing - I've had an issue with the change in verpy_plot/opt/rose-app-metoffice.conf.
Running with EXPID='METO_UKV' gives a verpy plotting error. Replacing this with EXPID=METO_UKV (removing quotes) works.
Creating an empty rose-app-metoffice.conf file (like niwa implementation) also doesn't work.

@JorgeBornemann
Copy link
Copy Markdown
Collaborator

Hi, having pulled this PR for testing - I've had an issue with the change in verpy_plot/opt/rose-app-metoffice.conf. Running with EXPID='METO_UKV' gives a verpy plotting error. Replacing this with EXPID=METO_UKV (removing quotes) works. Creating an empty rose-app-metoffice.conf file (like niwa implementation) also doesn't work.

Hi mo-tomosevans , This will be resolved in #2103, where EXPID (or rather EXPIDS) will be taken from the model names defined for the whole workflow via the rose gui. This will provide consistency between the CSET diagnostics and the METPlus/VerPy output.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Reflecting here what we discussed in person that the optional configurations in the metplus_ascii2nc app go in the main CSET repository rather than the restricted files, because they are unlikely to have any site-sensitive information.

Also noting that some of the changes will benefit other sites rather than Met Office.

MET_INSTALL_DIR=${MET_DIR}
CONDA_VENV_LOCATION = ${CONDA_METPLUS_VENV_LOCATION}
METPLUS_OBS_DIR=${METPLUS_OBS_DIR}
METPLUS_OPT_CONFIG_KEYS = metoffice
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The METPLUS_OPT_CONFIG_KEYS environment configuration is likely to be redundant, as it should not be using this file if it was no already metoffice, but is also harmless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding new VerPy capability for using at UK Met Office

3 participants