Adds windspeed below the MAUL#2140
Open
David Flack (daflack) wants to merge 9 commits into
Open
Conversation
Contributor
|
|
Collaborator
Author
|
Version for review will be refactored in #2114. |
Collaborator
Author
|
I haven't tested the recipes, but the code works as expected. Therefore, I am happy to put out for review. Please do not merge until #2119 has been merged. When reviewing please note comment above. |
David Flack (daflack)
requested review from
James Frost (jfrost-mo) and
James Warner (jwarner8)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a windspeed property diagnostic to the MAUL calculation to find windspeed below the MAUL.
Fixes #1963
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
rose-suite.conf.examplehas been updated if new diagnostic added.