Exp efficiency code edit #45
Exp efficiency code edit #45Jennifer Weeks (mo-jenniferweeks) wants to merge 2 commits intoMetOffice:profsea-climatefrom
Conversation
Edit exp efficiency code
Hemant Khatri (hmkhatri)
requested review from
Greg Munday (gregrmunday) and
Hemant Khatri (hmkhatri)
and removed request for
Greg Munday (gregrmunday)
|
|
||
| therm_med = np.percentile(self.OHC_change, 50, axis=0) * self.exp_efficiency | ||
| therm_med = np.percentile(self.OHC_change * self.exp_efficiency, 50, axis=0) | ||
| therm_std = np.std(self.OHC_change * self.exp_efficiency, axis=0) |
There was a problem hiding this comment.
I wonder if self.exp_efficienty should be outside the percentile bracket in both therm_med and therm_std. This way it would be consistent with the following code (if T_percentile data is supplied as an input)
ProFSea-tool/profsea/emulator/gmslr.py
Lines 393 to 399 in f839e46
Greg Munday (@gregrmunday) What do you think?
There was a problem hiding this comment.
I think here we should switch to using the sample_members_2D function in order to select 'real' as opposed to statistical members associated with each percentile. Then, it shouldn't matter whether you put it in or outside the bracket :)
There was a problem hiding this comment.
That sounds good.
Jennifer Weeks (@mo-jenniferweeks) Could you make the changes, as suggested by Greg Munday (@gregrmunday) ?
3 participants
Small code change - I've brought the expansion efficiency into the brackets