Extend plugin_executor to catch warnings during msg construction and …#104
Conversation
robertplatt-mo
force-pushed
the
catch_and_extend_msg_construction_warnings_in_plugin_executor
branch
from
ac6e008 to
2103a45
Compare
…append the plugin filepath to the warning message.
robertplatt-mo
force-pushed
the
catch_and_extend_msg_construction_warnings_in_plugin_executor
branch
2 times, most recently
from
1fb0c03 to
09daad6
Compare
robertplatt-mo
force-pushed
the
catch_and_extend_msg_construction_warnings_in_plugin_executor
branch
from
9844df5 to
47673b2
Compare
|
Carwyn Pelley (@cpelley) In order to get the CI to run I had to make changes to how the code is checked out for forks. I'm not expecting this to be merged I just wanted the CI to run. The change to the docs could feasibly me merged as it just ensures that when we push from a fork we skip the task that pushes the documentation. I know I need to add my name to contributors but I figured I'd let you feedback first. |
| - name: Commit and push documentation changes | ||
| if: steps.check-docs.outputs.changed == 'true' | ||
|
|
||
| if: ${{ steps.check-docs.outputs.changed == 'true' && !github.event.pull_request.head.repo.fork }} |
There was a problem hiding this comment.
Apologies for this. I updated the repository to require forks without consideration of the its impact to the actions.
Let's go with your changes to the workflow for now -- I'll put on my todo to update the actions to properly work with forks 👍
There was a problem hiding this comment.
Hi. Sorry I've been on leave. I'm actually not sure what the request is here. Do you mean we should keep my changes to workflows/tests.yml for now? If so what are next steps?
2 participants
…append the plugin filepath to the warning message.