Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9f707323a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | expirationTime | time at which offer to sign agreement (purchasing the SAFTE) expires | | ||
| | governingJurisdiction | jurisdiction of incorporation and also jurisdiction of governing law for the agreement | | ||
| | disputeResolution | method of dispute resolution | | ||
| | unlockStartTimeType |"tokenWarrantTime" \|"tgeTime" \| "setTime" | |
There was a problem hiding this comment.
The template lists unlockStartTimeType values as tokenWarrantTime|tgeTime|setTime, but SAFTEExtension serializes tokenWarrantTime to the string agreementDateTime (see src/storage/extensions/SAFTEExtension.sol around lines 137–140). If clients or the UI validate SAFTE metadata against this template, they will reject or mis-map the on-chain value, breaking SAFTE metadata rendering. Consider updating the template to use agreementDateTime (or adjusting the extension) so the documented values match what the contract emits.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@merisman will leave it to you to evaluate and resolve this comment
…AFTE reg D v 1..md
1 participant
Motivation
SAFT/TokenWarranttemplates so theSAFTEExtensioninsrc/storage/extensions/SAFTEExtension.solhas a corresponding human-readable template and UI field mapping, with unknown URLs left as placeholders.Description
templates/MetaLeX cyberSAFTE reg D v 1.0.mdthat defines global fields, party fields, theSAFTEDataextension struct (aligned withSAFTEExtension), relevant enums, and restrictive legends, with bracketed placeholders for external URIs and IDs.Testing
Codex Task