Conversation
…vert meeting notes to single-party agreement. Leave updated tests in pending feature branch
merging dev into partial scripify
Detoo
reviewed
Jan 30, 2026
| block.chainid, | ||
| "/script/res/known-cyber-corps.json", | ||
| maxCount | ||
| ); |
Contributor
There was a problem hiding this comment.
Just a note here because I haven't reviewed related files yet. If the legacy corps need state migration, we will need to migrate them one-by-one like last time.
Detoo
reviewed
Jan 30, 2026
Comment on lines
+59
to
+64
| IssuanceManagerFactory imFactory = IssuanceManagerFactory( | ||
| factoryProxy.issuanceManagerFactory() | ||
| ); | ||
| imFactory.setRefImplementation(address(newImImpl)); | ||
| imFactory.setCyberCertPrinterRefImplementation(address(newCertImpl)); | ||
| imFactory.setCyberScripRefImplementation(address(newScripImpl)); |
Contributor
There was a problem hiding this comment.
This only takes care of the v2 corps upgrades; for legacy corps however, since their beacon is owned by the legacy issuance manager factory, we will need to do upgrade from there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.