Conversation
…r (for createAccounts)
danroc
reviewed
Feb 6, 2026
| export function assertCreateAccountOptionTypeIsSupported< | ||
| Type extends CreateAccountOptions['type'], | ||
| >( | ||
| type: CreateAccountOptions['type'], |
Contributor
There was a problem hiding this comment.
Maybe we should assert the type of options instead of options.type.
Contributor
Author
There was a problem hiding this comment.
Yup, I agree, this would synergies pretty well with createAccounts params itself. I'll change this, thanks!
assertCreateAccountOptionTypeIsSupported helper (for createAccounts)assertCreateAccountOptionIsSupported helper (for createAccounts)
mathieuartu
previously approved these changes
Feb 9, 2026
mathieuartu
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper to guide TS and narrow down
CreateAccountOptions.typeto a specific set of values.This way, a
createAccountsimplementation can assert this and work with specifictypes rather than having to deal with a default branch/case for the unsupportedtypes.Note
Low Risk
Adds a small runtime assertion helper plus tests; no changes to keyring execution paths beyond optional use of the helper.
Overview
Adds a new
assertCreateAccountOptionIsSupportedhelper in the v2 create-account API to letcreateAccountsimplementations reject unsupportedCreateAccountOptions.typevalues and narrow the option type in TypeScript.Includes comprehensive unit tests covering supported/unsupported type behavior and compile-time narrowing expectations, and documents the addition in the
keyring-apichangelog.Written by Cursor Bugbot for commit ff8b694. This will update automatically on new commits. Configure here.