fix: fix re-use string for user-ops sender/to#465
Merged
Conversation
ccharly
commented
Feb 9, 2026
mathieuartu
approved these changes
Feb 9, 2026
sender/tostring for user-ops sender/to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently narrowed the type used for
EthAddressStructto beHex. This actually have a huge impact on various types that depend on it.While most of the account types are fine, the user-ops one also bubbles up to the
TransactionControllerand would require a bit more refactor to re-type everything correctly.For now, we'll just revert to what it was and keep them as
stringfor those types.Note
Medium Risk
Touches shared Ethereum address validation/types, which can ripple through downstream type inference and RPC param validation; behavior should be mostly compatible but type-level impacts are broad.
Overview
Reverts
EthAddressStruct’s inferred type back tostring(while keeping the same0x…{40}validation regex) to undo an unintended breaking change that propagated into ERC-4337/user-op address-like fields.Introduces
EthAddressStrictStruct(Hex-typed) for callers that need strictHexinference, and updates EIP-7702 authorization tuple validation to use this stricter struct. The changelog documents the revert and notes21.4.0will be yanked.Written by Cursor Bugbot for commit 2b1eb24. This will update automatically on new commits. Configure here.