Skip to content

Comments

fix: fix re-use string for user-ops sender/to#465

Merged
ccharly merged 7 commits intomainfrom
cc/fix/use-string-for-addresses
Feb 9, 2026
Merged

fix: fix re-use string for user-ops sender/to#465
ccharly merged 7 commits intomainfrom
cc/fix/use-string-for-addresses

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 6, 2026

We recently narrowed the type used for EthAddressStruct to be Hex. This actually have a huge impact on various types that depend on it.

While most of the account types are fine, the user-ops one also bubbles up to the TransactionController and would require a bit more refactor to re-type everything correctly.

For now, we'll just revert to what it was and keep them as string for those types.


Note

Medium Risk
Touches shared Ethereum address validation/types, which can ripple through downstream type inference and RPC param validation; behavior should be mostly compatible but type-level impacts are broad.

Overview
Reverts EthAddressStruct’s inferred type back to string (while keeping the same 0x…{40} validation regex) to undo an unintended breaking change that propagated into ERC-4337/user-op address-like fields.

Introduces EthAddressStrictStruct (Hex-typed) for callers that need strict Hex inference, and updates EIP-7702 authorization tuple validation to use this stricter struct. The changelog documents the revert and notes 21.4.0 will be yanked.

Written by Cursor Bugbot for commit 2b1eb24. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner February 6, 2026 15:36
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@ccharly ccharly changed the title fix: fix re-use string for user-ops sender/to fix: fix re-use string for user-ops sender/to Feb 9, 2026
@ccharly ccharly added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit d01338e Feb 9, 2026
37 checks passed
@ccharly ccharly deleted the cc/fix/use-string-for-addresses branch February 9, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants