Skip to content

Comments

fix: update mapping#466

Merged
montelaidev merged 10 commits intomainfrom
fix/update-mapping
Feb 9, 2026
Merged

fix: update mapping#466
montelaidev merged 10 commits intomainfrom
fix/update-mapping

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Feb 9, 2026

This PR updates the ledger mappings to update descriptions of errors and map them to the correct code.

Examples


Note

Low Risk
Changes only adjust Ledger error-code mappings/messages and corresponding tests; impact is limited to how transport errors are classified and displayed to users.

Overview
Updates Ledger status-code mappings to correctly treat 0x650f and 0x6d00 as DeviceStateEthAppClosed (instead of connection/V4-only errors) and adds a new mapping for 0x6a83 to represent Ethereum app closed while the device is on Solana, with clearer user-facing messages.

Refreshes unit tests in hw-wallet-sdk and the keyring-eth-ledger-bridge error handler to assert the new codes/messages, and documents the behavior in the hw-wallet-sdk changelog.

Written by Cursor Bugbot for commit b1e2788. This will update automatically on new commits. Configure here.

@montelaidev montelaidev requested a review from a team as a code owner February 9, 2026 09:07
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

montelaidev and others added 3 commits February 9, 2026 18:07
Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
@montelaidev montelaidev self-assigned this Feb 9, 2026
@montelaidev
Copy link
Contributor Author

Adding no-changelog because ledger package does not need a changelog

@montelaidev montelaidev enabled auto-merge February 9, 2026 11:02
@montelaidev
Copy link
Contributor Author

@metamaskbot publish-preview

@montelaidev montelaidev added this pull request to the merge queue Feb 9, 2026
Merged via the queue into main with commit aeea980 Feb 9, 2026
37 checks passed
@montelaidev montelaidev deleted the fix/update-mapping branch February 9, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants