Skip to content

chore: Update bridge controllers to expose all methods through messenger#8367

Open
Mrtenz wants to merge 8 commits intomainfrom
mrtenz/bridge-method-actions
Open

chore: Update bridge controllers to expose all methods through messenger#8367
Mrtenz wants to merge 8 commits intomainfrom
mrtenz/bridge-method-actions

Conversation

@Mrtenz
Copy link
Copy Markdown
Member

@Mrtenz Mrtenz commented Apr 2, 2026

Explanation

This updates the following controllers to expose all methods through the messenger in a standardised way:

  • BridgeController.
  • BridgeStatusController.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Low risk: changes are limited to new TypeScript action type exports, a build-time generation script dependency, and test refactoring; no bridge runtime logic is modified.

Overview
Adds an auto-generated bridge-controller-method-action-types.ts that defines and exports per-method messenger action types (e.g., BridgeControllerFetchQuotesAction) for all public BridgeController methods, and documents/deprecates the older aggregated action types in the changelog.

Updates package.json to support generating these types via a new generate-method-action-types script (adding tsx), and refactors the BridgeController SSE tests to exercise the controller through a real @metamask/messenger instance (rootMessenger.call(...)) instead of a hand-rolled messenger mock.

Written by Cursor Bugbot for commit 56740c7. This will update automatically on new commits. Configure here.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 2, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@Mrtenz Mrtenz force-pushed the mrtenz/bridge-method-actions branch from 0377135 to 0aa1851 Compare April 2, 2026 09:58
@Mrtenz Mrtenz marked this pull request as ready for review April 2, 2026 10:18
@Mrtenz Mrtenz requested review from a team as code owners April 2, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants