fix: avoid parent call on Traits #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahiarirani
changed the title
JoaoSRaposo
approved these changes
Oct 22, 2025
Collaborator
JoaoSRaposo
left a comment
JoaoSRaposo
left a comment
There was a problem hiding this comment.
Just did the following test:
- Checked that my local env had the logging message problem
- Checked that logging message problem in my dev env was the same as the ones in production
- Changed my dev machine to this PR
- Checked that the fatal message stop appearing
frozenbanana
added a commit
that referenced
this pull request
Oct 27, 2025
frozenbanana
added a commit
that referenced
this pull request
Oct 27, 2025
frozenbanana
added a commit
that referenced
this pull request
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the telemetry configuration logic by correcting the reference used to retrieve the application name.
parent::NAMEtoApplication::NAMEwhen fetching app info inconfigureTelemetry()inlib/AppInfo/Telemetry.phpto ensure the correct application name is used.