Skip to content

fix: only show unlisted project chip when it's the main project #4690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SylvainChevalier wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: only show unlisted project chip when it's the main project #4690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions front_end/src/app/(main)/questions/[id]/components/sidebar/sidebar_question_projects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { FC } from "react";
import SidebarContainer from "@/app/(main)/questions/[id]/components/sidebar/sidebar_container";
import Chip from "@/components/ui/chip";
import { PostWithForecasts } from "@/types/post";
import { TaxonomyProjectType } from "@/types/projects";
import { ProjectVisibility, TaxonomyProjectType } from "@/types/projects";
import { sendAnalyticsEvent } from "@/utils/analytics";
import { getProjectLink } from "@/utils/navigation";

Expand All @@ -24,6 +24,7 @@ const SidebarQuestionProjects: FC<Props> = ({ projects: projectsData }) => {
community: _community,
index: _index,
leaderboard_tag: _leaderboard_tag,
default_project,
} = projectsData;
const category = _category ?? [];
const tournament = _tournament ?? [];
Expand All @@ -32,14 +33,20 @@ const SidebarQuestionProjects: FC<Props> = ({ projects: projectsData }) => {
const index = _index ?? [];
const leaderboard_tag = _leaderboard_tag ?? [];

const defaultProjectId = default_project?.id;
const allProjects = [
...index,
...tournament,
...question_series,
...community,
...category,
...leaderboard_tag,
];
].filter(
(project) =>
!("visibility" in project) ||
project.visibility !== ProjectVisibility.Unlisted ||
project.id === defaultProjectId
);

const getChipText = (name: string, type?: string) =>
type === "leaderboard_tag" ? `🏆 ${name}` : name;
Expand Down
Loading