Empty / pre-CP-reveal audit for the new side-by-side row#4700
Conversation
… card for binary and continuous questions
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
…de layout left panel and fix title overflow onto the CP block
…forecaster title row and left panel
… on the question detail page
…ype left panels for the side-by-side layout
Summary
This PR audits and fixes the three hidden-CP states - user preference (
hideCP), pre-reveal time (cpRevealsOn), and no forecasts yet (isEmpty) - across the new side-by-side question layout introduced in the previous PR.Implemented fixes:
QuestionHeaderCPStatus): restructured into three early-return states - empty outline box with a centered "Current estimate" label whenisEmpty, centeredUpcomingCPcountdown whencpRevealsOn, centeredRevealCPButtonwhenhideCP- so the column width is always preserved and the correct state is always shownQuestionHeaderCPStatus): addedhideCPearly return that renders a centeredRevealCPButtoninside the fixed-width container for both forecaster desktop and mobileContinuousQuestionPrediction): addedhideCPguard that replaces the mini-chart tile with a centeredRevealCPButtonon mobilequestion_page_shell/index.tsx): wiredhideCP→RevealCPButtonandcpRevealsOn→UpcomingCPin the shell, removing the need for downstream components to handle these statesVictoryCursorContainer(replacing it withVictoryContainer) whenhideCPorcpRevealsOnis active, so no hover line appears over a blank chartRevealCPButtonrendered inside the histogram view - it duplicated the one already shown in the left paneltitle_row.tsx): fixed long or URL-heavy titles overflowing onto the CP status panelDemo videos
Consumer view (desktop, mobile)
1.mp4
2.mp4
3.mp4
4.mp4
Forecaster view (desktop, mobile)
5.mp4
6.mp4
7.mp4
8.mp4
Consumer and Forecaster views (desktop, mobile)
9.mp4