Skip to content

Empty / pre-CP-reveal audit for the new side-by-side row#4700

Open
ncarazon wants to merge 6 commits intofeat/question-page-redesign-2nd-iterationfrom
feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row
Open

Empty / pre-CP-reveal audit for the new side-by-side row#4700
ncarazon wants to merge 6 commits intofeat/question-page-redesign-2nd-iterationfrom
feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row

Conversation

@ncarazon
Copy link
Copy Markdown
Contributor

@ncarazon ncarazon commented May 7, 2026

Summary

This PR audits and fixes the three hidden-CP states - user preference (hideCP), pre-reveal time (cpRevealsOn), and no forecasts yet (isEmpty) - across the new side-by-side question layout introduced in the previous PR.

Implemented fixes:

  • Continuous left panel (QuestionHeaderCPStatus): restructured into three early-return states - empty outline box with a centered "Current estimate" label when isEmpty, centered UpcomingCP countdown when cpRevealsOn, centered RevealCPButton when hideCP - so the column width is always preserved and the correct state is always shown
  • Binary left panel (QuestionHeaderCPStatus): added hideCP early return that renders a centered RevealCPButton inside the fixed-width container for both forecaster desktop and mobile
  • Consumer continuous mobile (ContinuousQuestionPrediction): added hideCP guard that replaces the mini-chart tile with a centered RevealCPButton on mobile
  • Consumer binary left card (question_page_shell/index.tsx): wired hideCPRevealCPButton and cpRevealsOnUpcomingCP in the shell, removing the need for downstream components to handle these states
  • Timeline hover cursor: suppressed the VictoryCursorContainer (replacing it with VictoryContainer) when hideCP or cpRevealsOn is active, so no hover line appears over a blank chart
  • Histogram duplicate button: removed the RevealCPButton rendered inside the histogram view - it duplicated the one already shown in the left panel
  • Title row overflow (title_row.tsx): fixed long or URL-heavy titles overflowing onto the CP status panel

Demo videos

Consumer view (desktop, mobile)

  • Empty state
1.mp4
  • Revealed on
2.mp4
  • Hidden CP
3.mp4
  • Other charts
4.mp4

Forecaster view (desktop, mobile)

  • Empty state
5.mp4
  • Revealed on
6.mp4
  • Hidden CP
7.mp4
  • Other charts
8.mp4

Consumer and Forecaster views (desktop, mobile)

  • Empty state with Top key factors placeholder
9.mp4

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c1c8cb7f-a715-42e1-b73f-0a2a572d8fb5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

🚀 Preview Environment

Your preview environment is ready!

Resource Details
🌐 Preview URL https://metaculus-pr-4700-feat-empty-pre-cp-reveal-audit-preview.mtcl.cc
📦 Docker Image ghcr.io/metaculus/metaculus:feat-empty-pre-cp-reveal-audit-for-the-new-side-by-side-row-ad9b7c1
🗄️ PostgreSQL NeonDB branch preview/pr-4700-feat-empty-pre-cp-reveal-audit
Redis Fly Redis mtc-redis-pr-4700-feat-empty-pre-cp-reveal-audit

Details

  • Commit: ad9b7c12ca48ae45233259cb129d5aaf962e8f62
  • Branch: feat/empty-pre-cp-reveal-audit-for-the-new-side-by-side-row
  • Fly App: metaculus-pr-4700-feat-empty-pre-cp-reveal-audit

ℹ️ Preview Environment Info

Isolation:

  • PostgreSQL and Redis are fully isolated from production
  • Each PR gets its own database branch and Redis instance
  • Changes pushed to this PR will trigger a new deployment

Limitations:

  • Background workers and cron jobs are not deployed in preview environments
  • If you need to test background jobs, use Heroku staging environments

Cleanup:

  • This preview will be automatically destroyed when the PR is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant