Add spectate_mode.lua for spectate/freecam mode#19
Conversation
…/spectate_mode.lua
|
I disagree with @Cynosphere opinion on making things autorun, this crowds in the Might need @Python1320 to make a loader before the situation gets more out of control. |
|
It's relatively trivial to script noticing file name conflicts so it's fine but yeah somewhat more unique name would be better to avoid conflicts. Folder is overkill. Doesn't look like code will conflict, but probably don't want to allow this to work on non-sandbox (or even sandbox derived like Dark RP) but incubator scripts are not loaded on those anyway right now. Also on sandbox if allow lua files is disabled this might allow cheating (for example the "build-RP" area had the great idea that you could only join it if you haven't enabled lua running on your client). Okay to merge in my opinion even if it won't really work on metastruct due to PVS (you won't get frequent player's location updates if you're not in the same area). |
Just because you can put a band-aid afterwards is not "fine", I agree that in this case a folder for this file alone might be overkill, though I was thinking more for the incubator files altogether. Besides the day we forget about that band-aid we will have issues, and it will be very annoying to debug. |
This PR adds the
lua/autorun/spectate_mode.luascript, providing a basic spectate/freecam mode.Originally both this file and another feature were included in a single pull request (#18). To simplify review, I'm splitting them up. This pull request only contains the spectate mode script.
Please let me know if any changes are needed.