Stop using Apt class to avoid duplicate declaration and use conf.d file to make Apt use the proxy #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to make Apt use the proxy
Member
|
can you remove the apt module dependency here: https://github.com/MiamiOH/puppet-httpproxy/blob/master/metadata.json#L24 |
edestecd
reviewed
Aug 6, 2020
| }, | ||
| file { 'apt_via_proxy': | ||
| ensure => $httpproxy::packagemanager::ensure, | ||
| path => '/etc/apt/apt.conf.d/05proxy', |
Member
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-apt/blob/v7.1.0/manifests/init.pp#L194
I suggest /etc/apt/apt.conf.d/01proxy so that we don't end up with 2 files when converting and maintain backwards compatability
edestecd
reviewed
Aug 6, 2020
| group => 'root', | ||
| mode => '0644', | ||
| content => "Acquire::http::Proxy \"http://${httpproxy::http_proxy}:${httpproxy::http_proxy_port}\";", | ||
| } |
Member
There was a problem hiding this comment.
The old way also does an apt::update: https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/setting.pp#L63
Are we ok with losing that functionality?
edestecd
reviewed
Aug 6, 2020
| owner => 'root', | ||
| group => 'root', | ||
| mode => '0644', | ||
| content => "Acquire::http::Proxy \"http://${httpproxy::http_proxy}:${httpproxy::http_proxy_port}\";", |
Member
There was a problem hiding this comment.
https://github.com/puppetlabs/puppetlabs-apt/blob/v7.1.0/templates/proxy.epp#L2
Acquire::http::proxy
DOn't know if case matters here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.