Skip to content

Fix invitation IDOR and worker callback authorization gaps#229

Merged
MichielDean merged 4 commits into
mainfrom
feat/sc-d9v2m
Apr 14, 2026
Merged

Fix invitation IDOR and worker callback authorization gaps#229
MichielDean merged 4 commits into
mainfrom
feat/sc-d9v2m

Conversation

@MichielDean
Copy link
Copy Markdown
Owner

Closes droplet sc-d9v2m.

Cistern Agent added 4 commits April 13, 2026 22:15
- Invitation List/Revoke: add claims.TeamID != teamID check before
  role check, returning 403 for cross-team access
- Invitation Create: same team membership check added
- ReportProgress/ReportTestResult/ReportWorkerStatus: add auth
  check (claims nil → 401), DB nil check (→ 503), and
  ownsExecution verification (→ 404)
- Add ownsExecution helper method using SELECT EXISTS
- 9 new tests covering both IDOR and auth gap scenarios
- Fix existing tests that had mismatched team IDs (claims vs URL)
…rtProgress/ReportTestResult/ReportWorkerStatus preamble
@MichielDean MichielDean enabled auto-merge (squash) April 14, 2026 04:34
@MichielDean MichielDean merged commit 28c7f9f into main Apr 14, 2026
15 of 17 checks passed
@MichielDean MichielDean deleted the feat/sc-d9v2m branch April 14, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant