Fix reliability issues — goroutine leak, panics, non-transactional writes#231
Merged
Conversation
…tional writes - APITokenStore.Lookup: replace unbounded goroutine with synchronous last_used_at update using the request context - jwt.go: NewJWTManager returns error instead of panic for short secret - csrf.go: CSRFMiddleware, SetCSRFCookie, generateSignedToken return errors instead of panic; validate HMAC key is not empty - embed.go: Mount returns error instead of panic on FS creation failure - routes.go: handle all new error returns from JWT, CSRF, SPA mount - executions.go: wrap INSERT in transaction, launch K8s job outside tx, use dedicated markExecutionFailed with its own transaction for failure status updates - Update all callers and tests for new error-return signatures
MichielDean
force-pushed
the
feat/sc-q4slr
branch
from
7053146 to
fbcfa8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes droplet sc-q4slr.