Skip to content

Remove hardcoded GPG passphrase from pom.xml#48

Open
micheleh wants to merge 1 commit intomasterfrom
fix/remove-hardcoded-gpg-passphrase
Open

Remove hardcoded GPG passphrase from pom.xml#48
micheleh wants to merge 1 commit intomasterfrom
fix/remove-hardcoded-gpg-passphrase

Conversation

@micheleh
Copy link
Copy Markdown
Collaborator

@micheleh micheleh commented Apr 3, 2026

Summary

  • Removed the ossrh Maven profile which contained a hardcoded gpg.passphrase value in source control, active by default on every build
  • Moved gpg.executable=gpg2 to the sign profile where it's actually used
  • GPG passphrases should be provided via ~/.m2/settings.xml or environment variables, not committed to the repository

Context

The passphrase value (https://github.com/HPSoftware/bdd2octane) was a copy-paste artifact from another project (introduced in 38de43bf, 2021-11-25) — not a real secret — but hardcoding credentials in pom.xml is a bad practice that should be cleaned up.

Verification

  • mvn clean install — builds and unit tests pass (integration test failure is pre-existing on master, unrelated)
  • sign profile correctly picks up gpg.executable=gpg2

The ossrh profile contained a gpg.passphrase property hardcoded in
source control (activeByDefault=true). Removed the entire profile
and moved gpg.executable to the sign profile where it belongs.
GPG passphrases should be configured via ~/.m2/settings.xml or
environment variables, never in the POM.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@micheleh micheleh requested a review from nissimshitrit April 3, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant