Open
Conversation
The ossrh profile contained a gpg.passphrase property hardcoded in source control (activeByDefault=true). Removed the entire profile and moved gpg.executable to the sign profile where it belongs. GPG passphrases should be configured via ~/.m2/settings.xml or environment variables, never in the POM. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ossrhMaven profile which contained a hardcodedgpg.passphrasevalue in source control, active by default on every buildgpg.executable=gpg2to thesignprofile where it's actually used~/.m2/settings.xmlor environment variables, not committed to the repositoryContext
The passphrase value (
https://github.com/HPSoftware/bdd2octane) was a copy-paste artifact from another project (introduced in38de43bf, 2021-11-25) — not a real secret — but hardcoding credentials in pom.xml is a bad practice that should be cleaned up.Verification
mvn clean install— builds and unit tests pass (integration test failure is pre-existing on master, unrelated)signprofile correctly picks upgpg.executable=gpg2