Fix NullPointerException in CucumberJvmHandler and FilesLocator#53
Open
Fix NullPointerException in CucumberJvmHandler and FilesLocator#53
Conversation
Add null check for findLastNonEmptyLine() return value before dereferencing in CucumberJvmHandler.setElement(). Guard against File.listFiles() returning null in FilesLocator with a descriptive error message instead of NPE. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CucumberJvmHandlerline 96 before callingstartsWith()on the result offindLastNonEmptyLine(), which returns null for empty/whitespace-only error messagesFile.listFiles()inFilesLocator, throwing a descriptiveRuntimeExceptioninstead of NPE when a directory cannot be readContext
Both issues have existed since the initial commit (c71ed1f, 2021-11-15). The
CucumberJvmHandlercaller was modified 3 times by 3 different authors — none added a null check. A failure element with empty text content (e.g.,"\n\n\n") would crash the entire conversion process.Verification