Propagate error in FileUtil.getFileCreationTime#55
Open
Conversation
Replace silent empty string return with RuntimeException when file creation time cannot be read. The empty string caused started="" in the output XML, silently producing wrong data that ALM Octane could not interpret as a timestamp. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileUtil.getFileCreationTime()now throwsRuntimeExceptioninstead of silently returning""when the file cannot be readContext
Since the initial commit (c71ed1f, 2021-11-15), this method caught
IOExceptionand returned an empty string with the comment//TODO:error just return empty, log error. That TODO was never addressed in 4.5 years.The empty string flows through
OctaneFeature.setStarted("")into the output XML asstarted="", where ALM Octane expects a millisecond timestamp. The user gets silently wrong output with no warning. Notably, the same class already throwsRuntimeExceptioningetResultFilePath()on failure — this fix makes error handling consistent.Verification