Open
Conversation
The old xmlunit:xmlunit:1.6 artifact has insecure defaults when processing XSLT stylesheets (CVE-2024-31573), which can lead to arbitrary code execution with untrusted input. Replace with org.xmlunit:xmlunit-legacy:2.10.0, a drop-in API-compatible wrapper around the fixed xmlunit-core 2.10.0. Also added test scope since xmlunit is only used in integration tests. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmlunit:xmlunit:1.6withorg.xmlunit:xmlunit-legacy:2.10.0toremediate CVE-2024-31573 (insecure XSLT extension function defaults)
xmlunit-legacyprovides the sameorg.custommonkey.xmlunit.*API — no codechanges required
<scope>test</scope>since the dependency is only used in integrationtests, keeping it out of the shipped fat JAR
Test plan
mvn compile test-compile— compiles cleanlymvn test— all unit tests passmvn dependency:treeconfirmsxmlunit-core:2.10.0(with the fix) isresolved and old
xmlunit:1.6is gone