Skip to content

Fixed using the wrong protocol version #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MinnDevelopment merged 1 commit into from
Feb 28, 2026
Merged

Fixed using the wrong protocol version #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion api/src/main/java/club/minnced/discord/jdave/DaveSessionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ public static DaveSessionImpl create(@Nullable String authSessionId) {
MemorySegment authSessionIdSegment =
authSessionId != null ? local.allocateFrom(authSessionId) : MemorySegment.NULL;
MemorySegment session = LibDaveSessionBinding.createSession(MemorySegment.NULL, authSessionIdSegment);
return new DaveSessionImpl(session);

DaveSessionImpl result = new DaveSessionImpl(session);
// this part of memory is not initialized by libdave
// until we call #initialize or #reset meaning it just
// has a random value of whatever was there before making
// it very confusing to debug
result.setProtocolVersion((short) -1);
return result;
}
}

Expand Down
7 changes: 4 additions & 3 deletions api/src/main/java/club/minnced/discord/jdave/manager/DaveSessionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public synchronized void onMLSPrepareCommitTransition(int transitionId, @NonNull
prepareProtocolTransition(transitionId, session.getProtocolVersion());
} else {
sendInvalidCommitWelcome(transitionId);
handleDaveProtocolInit(transitionId);
handleDaveProtocolInit(session.getProtocolVersion());
}
}
}
Expand All @@ -247,7 +247,7 @@ public synchronized void onMLSWelcome(int transitionId, @NonNull ByteBuffer welc
prepareProtocolTransition(transitionId, session.getProtocolVersion());
} else {
sendInvalidCommitWelcome(transitionId);
handleDaveProtocolInit(transitionId);
handleDaveProtocolInit(session.getProtocolVersion());
}
}

Expand Down Expand Up @@ -292,9 +292,10 @@ private void prepareProtocolTransition(int transitionId, int protocolVersion) {
encryptor.processTransition(protocolVersion);
} else {
preparedTransitions.put(transitionId, protocolVersion);
currentProtocolVersion = protocolVersion;
callbacks.sendDaveProtocolReadyForTransition(transitionId);
}

currentProtocolVersion = protocolVersion;
}

private void executeProtocolTransition(int transitionId) {
Expand Down