GEOPY-2700: Random failure of name incrementor test#842
Merged
domfournier merged 2 commits intodevelopfrom Feb 13, 2026
Merged
Conversation
github-actions
bot
changed the title
MatthieuCMira
requested changes
Feb 12, 2026
Contributor
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
doesn't hjave to be random lenght
tests/reference_data_test.py
Outdated
| random_len = random.randint(2, n_class) | ||
| value_map[ref] = "".join( | ||
| random.choice(string.ascii_lowercase) for i in range(random_len) | ||
| random.choice(string.ascii_lowercase) for _ in range(random_len) |
Contributor
There was a problem hiding this comment.
Can just be a long word
Suggested change
| random.choice(string.ascii_lowercase) for _ in range(random_len) | |
| random.choice(string.ascii_lowercase) for _ in range(5) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2700 - Random failure of name incrementor test
The random name generator could sometimes give two classes with the same name, more likely to happen for single-letter class names. It will be much rarer if we have a mimimum of 2 letters per name.