GEOPY-2690: Block model export to OMF with offset by half cell#115
Open
domfournier wants to merge 3 commits intodevelopfrom
Open
GEOPY-2690: Block model export to OMF with offset by half cell#115domfournier wants to merge 3 commits intodevelopfrom
domfournier wants to merge 3 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #115 +/- ##
===========================================
+ Coverage 92.58% 92.82% +0.24%
===========================================
Files 27 27
Lines 1511 1506 -5
===========================================
- Hits 1399 1398 -1
+ Misses 112 108 -4
🚀 New features to boost your workflow:
|
MatthieuCMira
requested changes
Feb 12, 2026
MatthieuCMira
left a comment
MatthieuCMira
left a comment
There was a problem hiding this comment.
seems simpler.
Just see my comment
omf/fileio/geoh5.py
Outdated
| if key == "origin": | ||
| prop = getattr(element, key, None) | ||
| else: | ||
| prop = getattr(element, key, None) |
There was a problem hiding this comment.
???
both conditions are the same no?
Author
There was a problem hiding this comment.
yea, my bad. Was for testing....
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2690 - Block model export to OMF with offset by half cell