Skip to content

Comments

GEOPY-1962: Convert all of potential fields to BaseData params class#135

Merged
domfournier merged 11 commits intodevelopfrom
GEOPY-1962
Jan 31, 2025
Merged

GEOPY-1962: Convert all of potential fields to BaseData params class#135
domfournier merged 11 commits intodevelopfrom
GEOPY-1962

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Jan 30, 2025

GEOPY-1962 - Convert all of potential fields to BaseData params class

@github-actions github-actions bot changed the title Geopy 1962 GEOPY-1962: Convert all of potential fields to BaseData params class Jan 30, 2025
@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (7a0c6aa) to head (39bdc08).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
- Coverage    91.35%   90.27%   -1.09%     
===========================================
  Files           92       92              
  Lines         5172     4731     -441     
  Branches       556      552       -4     
===========================================
- Hits          4725     4271     -454     
- Misses         316      333      +17     
+ Partials       131      127       -4     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 95.43% <100.00%> (+0.02%) ⬆️
...peg_drivers/components/factories/source_factory.py 90.00% <100.00%> (ø)
simpeg_drivers/components/locations.py 88.23% <100.00%> (ø)
simpeg_drivers/potential_fields/__init__.py 100.00% <100.00%> (ø)
...ivers/potential_fields/magnetic_scalar/__init__.py 100.00% <100.00%> (ø)
...drivers/potential_fields/magnetic_scalar/driver.py 100.00% <100.00%> (ø)
...drivers/potential_fields/magnetic_scalar/params.py 100.00% <100.00%> (+0.77%) ⬆️
...ivers/potential_fields/magnetic_vector/__init__.py 100.00% <100.00%> (ø)
...drivers/potential_fields/magnetic_vector/driver.py 82.14% <100.00%> (+0.66%) ⬆️
...drivers/potential_fields/magnetic_vector/params.py 100.00% <100.00%> (+0.69%) ⬆️
... and 3 more

... and 1 file with indirect coverage changes

@domfournier domfournier merged commit 7aa420b into develop Jan 31, 2025
11 checks passed
@domfournier domfournier deleted the GEOPY-1962 branch January 31, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants