Skip to content

Comments

GEOPY-1879: Use MetaSimulations instead of custom misfit mapping towards distributed process#138

Merged
benk-mira merged 42 commits intodevelopfrom
GEOPY-1879
Feb 7, 2025
Merged

GEOPY-1879: Use MetaSimulations instead of custom misfit mapping towards distributed process#138
benk-mira merged 42 commits intodevelopfrom
GEOPY-1879

Conversation

@domfournier
Copy link
Collaborator

@domfournier domfournier commented Feb 4, 2025

GEOPY-1879 - Use MetaSimulations instead of custom misfit mapping towards distributed process

# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	simpeg_drivers/components/factories/survey_factory.py
#	simpeg_drivers/driver.py
@github-actions github-actions bot changed the title GEOPY-1879 GEOPY-1879: Use MetaSimulations instead of custom misfit mapping towards distributed process Feb 4, 2025
domfournier and others added 6 commits February 4, 2025 15:42
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	simpeg_drivers/components/factories/misfit_factory.py
#	simpeg_drivers/driver.py
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, looks good!

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (d85841c) to head (901d5de).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
simpeg_drivers/joint/driver.py 66.66% 1 Missing and 1 partial ⚠️
simpeg_drivers/utils/testing.py 50.00% 1 Missing and 1 partial ⚠️
...peg_drivers/components/factories/misfit_factory.py 97.05% 0 Missing and 1 partial ⚠️
...g_drivers/components/factories/receiver_factory.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    90.25%   90.12%   -0.14%     
===========================================
  Files           92       92              
  Lines         4733     4782      +49     
  Branches       553      569      +16     
===========================================
+ Hits          4272     4310      +38     
- Misses         334      341       +7     
- Partials       127      131       +4     
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 95.65% <100.00%> (+0.22%) ⬆️
...peg_drivers/components/factories/survey_factory.py 91.73% <100.00%> (-3.23%) ⬇️
simpeg_drivers/utils/tile_estimate.py 91.33% <ø> (ø)
simpeg_drivers/utils/utils.py 70.77% <100.00%> (+0.08%) ⬆️
...peg_drivers/components/factories/misfit_factory.py 96.90% <97.05%> (-0.11%) ⬇️
...g_drivers/components/factories/receiver_factory.py 80.21% <66.66%> (-0.43%) ⬇️
simpeg_drivers/joint/driver.py 89.18% <66.66%> (-1.38%) ⬇️
simpeg_drivers/utils/testing.py 85.48% <50.00%> (+0.07%) ⬆️

benk-mira
benk-mira previously approved these changes Feb 6, 2025
@benk-mira benk-mira merged commit 90ec6c2 into develop Feb 7, 2025
11 checks passed
@benk-mira benk-mira deleted the GEOPY-1879 branch February 7, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants