Skip to content

Comments

GEOPY-1965: Convert all EM params to BaseData#143

Closed
benk-mira wants to merge 10 commits intodevelopfrom
GEOPY-1965
Closed

GEOPY-1965: Convert all EM params to BaseData#143
benk-mira wants to merge 10 commits intodevelopfrom
GEOPY-1965

Conversation

@benk-mira
Copy link
Contributor

@benk-mira benk-mira commented Feb 10, 2025

GEOPY-1965 - Convert all EM params to BaseData

@github-actions github-actions bot changed the title Geopy 1965 GEOPY-1965: Convert all EM params to BaseData Feb 10, 2025
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 94.64286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (e3b39ef) to head (ed58960).

Files with missing lines Patch % Lines
...rivers/electromagnetics/frequency_domain/params.py 88.57% 8 Missing ⚠️
...peg_drivers/electromagnetics/time_domain/params.py 98.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #143      +/-   ##
===========================================
- Coverage    88.55%   88.35%   -0.20%     
===========================================
  Files           92       92              
  Lines         4813     4775      -38     
  Branches       571      573       +2     
===========================================
- Hits          4262     4219      -43     
- Misses         419      423       +4     
- Partials       132      133       +1     
Files with missing lines Coverage Δ
...vers/electromagnetics/frequency_domain/__init__.py 100.00% <100.00%> (ø)
...rivers/electromagnetics/frequency_domain/driver.py 100.00% <100.00%> (ø)
...g_drivers/electromagnetics/time_domain/__init__.py 100.00% <100.00%> (ø)
...peg_drivers/electromagnetics/time_domain/driver.py 91.80% <100.00%> (-8.20%) ⬇️
simpeg_drivers/utils/write_default_uijson.py 0.00% <ø> (ø)
...peg_drivers/electromagnetics/time_domain/params.py 98.59% <98.30%> (-0.58%) ⬇️
...rivers/electromagnetics/frequency_domain/params.py 88.09% <88.57%> (-6.70%) ⬇️

@benk-mira benk-mira closed this Feb 12, 2025
@benk-mira benk-mira reopened this Feb 12, 2025
@benk-mira benk-mira closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant