Skip to content

GEOPY-2569: Wrong normalization for MT #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 6 commits into from
Nov 19, 2025
Merged

GEOPY-2569: Wrong normalization for MT #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94cd0f1
Remove normalization for MT
domfournier Nov 14, 2025
2c4964b
Update target
domfournier Nov 14, 2025
2a15d45
Merge branch 'release/ga-4.7' into GEOPY-2569
domfournier Nov 15, 2025
9bc0305
Increase tolerance for MT
domfournier Nov 17, 2025
1654226
Merge branch 'release/ga-4.7' into GEOPY-2569
domfournier Nov 17, 2025
682376b
Merge branch 'release/ga-4.7' into GEOPY-2569
domfournier Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simpeg_drivers/components/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ def get_normalizations(self):
if comp in ["gz", "bz", "gxz", "gyz", "bxz", "byz"]:
normalizations[chan][comp] = -1 * np.ones(self.mask.sum())
elif self.params.inversion_type in ["magnetotellurics"]:
normalizations[chan][comp] = -1 * np.ones(self.mask.sum())
normalizations[chan][comp] = np.ones(self.mask.sum())
elif self.params.inversion_type in ["tipper"]:
if "imag" in comp:
normalizations[chan][comp] = -1 * np.ones(self.mask.sum())
Expand Down
4 changes: 2 additions & 2 deletions tests/run_tests/driver_mt_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
# To test the full run and validate the inversion.
# Move this file out of the test directory and run.

target_run = {"data_norm": 0.032649770, "phi_d": 6.68, "phi_m": 263}
target_run = {"data_norm": 0.032649770, "phi_d": 7.13, "phi_m": 282}


def setup_data(workspace, survey):
Expand Down Expand Up @@ -187,7 +187,7 @@ def test_magnetotellurics_run(tmp_path: Path, max_iterations=1, pytest=True):
output["data"] = orig_zyy_real_1
assert not run_ws.get_entity("Iteration_0_sensitivities")[0]
if pytest:
check_target(output, target_run, tolerance=0.2)
check_target(output, target_run, tolerance=0.1)
nan_ind = np.isnan(run_ws.get_entity("Iteration_0_model")[0].values)
inactive_ind = run_ws.get_entity("active_cells")[0].values == 0
assert np.all(nan_ind == inactive_ind)
Expand Down
Loading