GEOPY-2661: Update minimum requirement to python >=3.12, <3.15 and numpy 2.*#345
GEOPY-2661: Update minimum requirement to python >=3.12, <3.15 and numpy 2.*#345domfournier wants to merge 4 commits intodevelopfrom
Conversation
github-actions
bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #345 +/- ##
========================================
Coverage 91.26% 91.26%
========================================
Files 120 120
Lines 6505 6505
Branches 785 785
========================================
Hits 5937 5937
Misses 379 379
Partials 189 189
🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
| scipy = "~1.14.0" | ||
| tqdm = "^4.66.1" | ||
| trimesh = "~4.1.3" | ||
| mkl-service = "~2.6.1" # for Windows crash in IDE |
There was a problem hiding this comment.
suggestion: make it a dev dependency if is only required for the IDE, but not from command line
|
|
||
| discretize = "0.11.*" # also in simpeg, grid-apps | ||
| distributed = "2025.3.*" # for dask[distributed] | ||
| numpy = "~1.26.0" # also in geoh5py, simpeg |
There was a problem hiding this comment.
issue: here, it must list all the direct dependencies of the package
Even if they also come as transitive dependencies
as simpeg-drivers does import numpy, it must be listed here. Please, also check the other ones that got removed by this diff
pyproject.toml
Outdated
| bokeh = "3.6.*" # optional, for dask reporting | ||
| fsspec = ">=2022.0" # from simpeg[dask] | ||
| geoana = "0.7.*" # from simpeg | ||
| h5py = ">=3.2.1, 3.*" # from geoh5py | ||
| matplotlib-base = ">=3.8.4, 3.8.*" # from geoapps-utils, simpeg | ||
| mkl = ">=2024.2.2" | ||
| Pillow = ">=10.3.0, 10.3.*" # from geoh5py | ||
|
|
||
| pymatsolver = "0.3.*" # from simpeg | ||
| zarr = ">=2.14.2, 2.14.*" # from simpeg[dask] | ||
| matplotlib-base = ">=3.10.0, <3.11.dev" # from geoapps-utils | ||
| Pillow = ">=12.1.0, <13.0.dev" # from geoh5py | ||
| h5py = ">=3.15.1, <4.0.dev" # from geoh5py | ||
| python_abi = ">=3.*" | ||
| numpy = ">=2.0.0" | ||
| scipy = ">=1.17.0" | ||
| rtree = ">=1.4.0" | ||
| scikit-learn = ">=1.8.0" | ||
| pydiso = ">=0.2.*" | ||
| python-mumps = ">=0.0.6.*" |
There was a problem hiding this comment.
suggestion: keep dependencies ordered alphabetically (easier to maintain the list)
pyproject.toml
Outdated
| Pillow = ">=12.1.0, <13.0.dev" # from geoh5py | ||
| h5py = ">=3.15.1, <4.0.dev" # from geoh5py | ||
| python_abi = ">=3.*" | ||
| numpy = ">=2.0.0" |
There was a problem hiding this comment.
issue: only list here indirect dependencies
See my related comment above about listing explicitly direct dependencies in another section of this file
| channels = ['conda-forge'] | ||
|
|
||
| [tool.conda-lock.dependencies] | ||
| libblas = "*=*mkl" # because simpeg already brings in the MKL |
There was a problem hiding this comment.
issue: keep forcing the mk implementation for libblas
otherwise we end up with both openblas and mkl on Linux because of pydiso which forces the mkl
(cherry picked from commit f19c57a)
2 participants
GEOPY-2661 - Update minimum requirement to python >=3.12, <3.15 and numpy 2.*