Skip to content

Fix: keep voice playback running when screen locks #6097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crossle merged 3 commits into from
Mar 18, 2026
Merged

Fix: keep voice playback running when screen locks #6097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12892d9
Fix: keep voice playback running when screen locks
SeniorZhai Jan 27, 2026
5aa66f2
Merge branch 'master' into opt/audio
crossle Jan 27, 2026
0ec49c4
Merge branch 'master' into opt/audio
crossle Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/one/mixin/android/MixinApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,7 @@ open class MixinApplication :
val appAuth = defaultSharedPreferences.getInt(Constants.Account.PREF_APP_AUTH, -1)
if (appAuth != -1) {
if (appAuth == 0) {
appAuthShown = true
AppAuthActivity.show(activity)
return true
} else {
Expand All @@ -472,6 +473,7 @@ open class MixinApplication :
Constants.INTERVAL_30_MINS
}
if (now - enterBackground > offset) {
appAuthShown = true
AppAuthActivity.show(activity)
return true
}
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/one/mixin/android/ui/conversation/ConversationFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,8 +1220,8 @@ class ConversationFragment() :
private var lastReadMessage: String? = null

override fun onPause() {
// don't stop audio player if triggered by screen off
if (powerManager.isInteractive) {
// don't stop audio player if triggered by screen off or app lock overlay
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment refers to "app lock overlay" but AppAuthActivity is a separate activity, not an overlay. Consider updating the comment to say "app lock screen" or "app authentication" for accuracy.

Suggested change
// don't stop audio player if triggered by screen off or app lock overlay
// don't stop audio player if triggered by screen off or app lock screen

Copilot uses AI. Check for mistakes.
if (powerManager.isInteractive && !MixinApplication.get().isAppAuthShown()) {
AudioPlayer.pause()
}
sensorManager.unregisterListener(this)
Expand Down
Loading