Skip to content

Conversation

@fredericsimard
Copy link
Contributor

Summary:

Translated the UI labels in 10 languages, did manual fixes on mistakes added by translator.

@fredericsimard fredericsimard added the enhancement New feature or request label Aug 15, 2024
@fredericsimard fredericsimard self-assigned this Aug 15, 2024
@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-681-pv9a1bn8.web.app

@fredericsimard fredericsimard requested a review from emmambd August 15, 2024 12:14
@fredericsimard fredericsimard changed the title Translations Feat: Translations Aug 15, 2024
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! As this repository is in active development, let's make sure that we create a development process that is easy to follow. It might be great if we introduce a way in the process to override text generated by the tool with community fixed text. Before making this public, we should implement the search in multiple languages as @emmambd suggested. I also suggest adding a disclaimer text pointing out the process to contribute to translations.

fredericsimard and others added 2 commits August 15, 2024 09:25
Co-authored-by: David Gamez <1192523+davidgamez@users.noreply.github.com>
@fredericsimard
Copy link
Contributor Author

@davidgamez I can install the automation to do the translation when a PR is opened for these specific files and then added to the PR for someone to revise and change what needs to. It's untested in prod but should work. I was waiting for the new gtfs.org website to be online before installing it there, but it's ready.

@davidgamez
Copy link
Member

@davidgamez I can install the automation to do the translation when a PR is opened for these specific files and then added to the PR for someone to revise and change what needs to. It's untested in prod but should work. I was waiting for the new gtfs.org website to be online before installing it there, but it's ready.

Let's connect to go over the details.

@github-actions
Copy link

*Lighthouse ran on https://mobility-feeds-dev--pr-681-i9svhyvo.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 96 🟢 100 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-681-i9svhyvo.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 69 🟢 91 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-681-i9svhyvo.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 89 🔴 0 🟢 96 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-681-i9svhyvo.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 95 🟠 88 🟢 100 🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-681-i9svhyvo.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 100 🟢 100 🟢 100 🟢 100

@github-actions
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-681-i9svhyvo.web.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants