Skip to content

Output a more descriptive error message if LoadLibrary fails. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UE4SS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Output a more descriptive error message if LoadLibrary fails. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <fstream>
#include <Windows.h>
#include <Psapi.h>
#include <strsafe.h>
#include <atlbase.h>
#include <dia2.h>
#include <DbgHelp.h>
Expand Down Expand Up @@ -117,6 +118,37 @@ bool DumpTypesForDebugFile(const std::filesystem::path& PDBFilePath, const std::
return true;
}

std::wstring GetLastErrorString(LPCTSTR lpszFunction)
{
// Retrieve the system error message for the last-error code

LPVOID lpMsgBuf;
LPVOID lpDisplayBuf;
DWORD dw = GetLastError();

FormatMessage(
FORMAT_MESSAGE_ALLOCATE_BUFFER |
FORMAT_MESSAGE_FROM_SYSTEM |
FORMAT_MESSAGE_IGNORE_INSERTS,
NULL,
dw,
MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),
(LPTSTR)&lpMsgBuf,
0, NULL);

lpDisplayBuf = (LPVOID)LocalAlloc(LMEM_ZEROINIT,
(lstrlen((LPCTSTR)lpMsgBuf) + lstrlen((LPCTSTR)lpszFunction) + 40) * sizeof(TCHAR));
StringCchPrintf((LPTSTR)lpDisplayBuf,
LocalSize(lpDisplayBuf) / sizeof(TCHAR),
TEXT("%s failed with error %d: %s"),
lpszFunction, dw, lpMsgBuf);
auto ErrorAsString = std::wstring{(LPCTSTR)lpDisplayBuf};

LocalFree(lpMsgBuf);
LocalFree(lpDisplayBuf);
return ErrorAsString;
}

int main(int argc, const char** argv) {
std::wcout << TEXT("Starting the UVTD") << std::endl;
std::filesystem::path CurrentDirectory = std::filesystem::absolute(TEXT("."));
Expand All @@ -129,6 +161,7 @@ int main(int argc, const char** argv) {
HMODULE DiaDllHandle = LoadLibraryW(DiaDllPath.wstring().c_str());
if (DiaDllHandle == nullptr) {
std::wcout << TEXT("Failed to load msdia140.dll file, make sure it's in the run director at ") << DiaDllPath << std::endl;
std::wcout << GetLastErrorString(TEXT("LoadLibrary")) << std::endl;
return 1;
}

Expand Down