[FIX] test_hymba#2872
Open
ZX-ModelCloud wants to merge 5 commits intomainfrom
Open
Conversation
2. hymba is compatible with Transformer v5. Signed-off-by: ZX-ModelCloud <zx@modelcloud.ai>
Signed-off-by: ZX-ModelCloud <zx@modelcloud.ai>
Signed-off-by: ZX-ModelCloud <zx@modelcloud.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix test_hymba
What Changed
1.
shared_kv_cache_dictwas only populated whenreuse_kv=True.That breaks models like Hymba where not every decoder layer has
reuse_kv=True: earlier layers may need to publish KV for later layers even when the current layer itself does not consumekv_last_layer. In those cases,prev_kvstays empty by the time a later layer actually needs it.This change adds a model-level
write_shared_kv_cacheswitch onBaseQModel, keeps the default behavior unchanged, and enables it for Hymba.2.
hymbais compatible withtransformers v5.