Skip to content

Allow for CMake generator override using environment var on Windows #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iemand005 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow for CMake generator override using environment var on Windows #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pcre_ext/pcre2-10.46
Open in desktop
Submodule pcre2-10.46 added at b2bd42
3 changes: 2 additions & 1 deletion setup_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,9 @@ def _has_built_library() -> bool:
]
# On Windows, force MSVC and the /MD runtime. Never let CMake pick MinGW.
if _is_windows_platform():
vs_gen = os.environ.get("CMAKE_GENERATOR", "Visual Studio 18 2022")
cmake_args += [
"-G", "Visual Studio 17 2022",
"-G", vs_gen,
"-A", "x64",
"-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL",
]
Expand Down