Set 5090 not support TMA and fix only audio_server#1237
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a new is_nvidia utility function and refines the triton_support_tensor_descriptor logic to specifically handle 5090 GPUs, aligning with the title's intent to exclude 5090 from TMA support. It also propagates an init_shm_data flag to the CpuEmbedCacheClient initialization. However, there is a potential semantic mismatch in how the init_shm_data flag is derived from self.args.disable_vision.
| "rank_id": rank_id, | ||
| "cache_port": self.cache_port, | ||
| "data_type": self.args.data_type, | ||
| "init_shm_data": self.args.disable_vision, |
There was a problem hiding this comment.
The init_shm_data parameter is being set using self.args.disable_vision. While this might functionally work if disable_vision happens to have the correct boolean value, its name suggests a purpose related to vision features, not shared memory data initialization for audio. This could lead to confusion or incorrect behavior if the meaning of disable_vision changes or if it's not always aligned with the intent of init_shm_data. It would be clearer and more robust to introduce a dedicated argument for init_shm_data or rename disable_vision if its scope has expanded.
No description provided.