Skip to content

fix: use enum comparison for socket family check#1241

Merged
shihaobai merged 1 commit intomainfrom
fix_socket
Mar 19, 2026
Merged

fix: use enum comparison for socket family check#1241
shihaobai merged 1 commit intomainfrom
fix_socket

Conversation

@sufubao
Copy link
Collaborator

@sufubao sufubao commented Mar 19, 2026

Summary

  • Replace fragile string comparison str(sock.family) != "AddressFamily.AF_UNIX" with proper enum comparison sock.family != socket.AF_UNIX
  • String representation of enums can vary across Python versions, making the original comparison unreliable
  • This is the correct, idiomatic way to compare enum values in Python

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors a socket family check to use direct enum comparison instead of string-based comparison. This change significantly improves the robustness and reliability of the code, ensuring consistent behavior across different Python environments by avoiding issues related to variable string representations of enum values.

Highlights

  • Robustness Improvement: Replaced a fragile string comparison for socket family (str(sock.family) != "AddressFamily.AF_UNIX") with a proper enum comparison (sock.family != socket.AF_UNIX).
  • Cross-Version Compatibility: Addressed potential unreliability due to varying string representations of enums across different Python versions.
  • Idiomatic Python: Implemented the correct and idiomatic way to compare enum values in Python, enhancing code clarity and maintainability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Replace fragile string comparison with proper enum comparison when
checking socket family type. String representation of enums can vary
across Python versions, making the comparison unreliable.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces a fragile string-based comparison for the socket address family with a more robust enum-based comparison. The original implementation using str(sock.family) is not portable across different Python versions, as the string representation of enums has changed. The updated code uses sock.family != socket.AF_UNIX, which is the correct and idiomatic way to perform this check, ensuring the logic works as expected regardless of the Python version.

@shihaobai shihaobai merged commit a087340 into main Mar 19, 2026
1 check passed
@shihaobai shihaobai deleted the fix_socket branch March 19, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants