Block entities using NMS#4
Open
Alvinn8 wants to merge 6 commits into
Open
Conversation
| run: | | ||
| git config --global user.email "no-reply@github.com" | ||
| git config --global user.name "Github Actions" | ||
| ./gradlew applyPatches --stacktrace |
Member
There was a problem hiding this comment.
I haven't looked at the build file since Paperweight updated. I kind of didn't want there to be proper JARs at first haha. But now it's time!
Contributor
Author
There was a problem hiding this comment.
I see. Now it instead fails because the dev bundle is not published. So jars still have to wait if that is desirable 😄
Ideally an appropriate subclass that provides plugins with a way to access custom data from the block entities shuold be returned here. For now, return CraftBlockState.
Additionally adds comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to register custom block entity types that can be used to make custom block entities. Currently, this is only doable using NMS. A next step would be to add a way to do this using the API, which I'm thinking can be a separate PR.
Translating to the client is straightforward since the client does not need to know which blocks are block entities, so the packets are skipped.