fix: override tooltip to Toggle cell alignment in tabular context only.#2938
fix: override tooltip to Toggle cell alignment in tabular context only.#2938Prashant27-07 wants to merge 2 commits intoMoganLab:mainfrom
Conversation
|
Fixes #2852 |
|
You should only change the behavior in tabular-like environment. The current change is global so when it comes to the math mode, it becomes: 
|
|
Also, documentation and PR number are required. |
Prashant27-07
force-pushed
the
fix-toggle-numbering-tooltip
branch
from
7c22ae7 to
4abd0e7
Compare
Prashant27-07
force-pushed
the
fix-toggle-numbering-tooltip
branch
from
4abd0e7 to
53d3326
Compare
|
Hi @JackYansongLi I have updated the fix. The tooltip change is now only applied in tabular context using table-markup-context? in table-menu.scm. The generic-menu.scm and text-menu.scm are reverted back to 'Toggle numbering'. Please review. |
|
@Prashant27-07 Please refer to the guidelines in https://github.com/MoganLab/mogan/blob/main/CONTRIBUTING.md, thanks. |
Prashant27-07
force-pushed
the
fix-toggle-numbering-tooltip
branch
from
53d3326 to
eec4fa9
Compare
|
Updated the commit to [222_51] and added the developer documentation file devel/222_51.md as required by CONTRIBUTING.md. The fix now correctly overrides the tooltip only in tabular context using table-markup-context?. |
|
please also change the title of this PR. |
Prashant27-07
changed the title
|
@JackYansongLi Done. |
3 participants
the tooltip "Toggle numbering" was misleading - the button actually toggles cell alignment (tabular vs tabular*), not numbering. Changed the tooltip to "Toggle cell alignment" in generic-menu.scm and text-menu.scm.