Skip to content

Improve DT Modifier coverage#128

Merged
FletcherDares merged 1 commit into
mainfrom
fletcher/improve-coverage-on-modifiers
Dec 16, 2025
Merged

Improve DT Modifier coverage#128
FletcherDares merged 1 commit into
mainfrom
fletcher/improve-coverage-on-modifiers

Conversation

@FletcherDares
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

AI review done up to commit: 7d34c12

AI Review Summary:

The changes introduce new test cases to the test_parse_modifier_error_cases function in src/db/table/operations/helpers/datetime_functions/modifiers.rs. These tests cover a comprehensive set of invalid date, time, and modifier string inputs, including leap year checks and out-of-range values. The overall quality of the changes is good, as they improve the test coverage and robustness of the parse_modifier function by explicitly testing various error conditions. No specific issues or patterns of errors were observed.

@FletcherDares FletcherDares merged commit f615a3d into main Dec 16, 2025
4 checks passed
@FletcherDares FletcherDares deleted the fletcher/improve-coverage-on-modifiers branch December 16, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant