Refactor DateTime operations to work correctly

[FletcherDares]

No description provided.

[github-actions]

AI review done up to commit: 91ce73b

AI Review Summary:

Code review completed. Reviewed 0 files with 0 comments.

[github-actions]

AI review done up to commit: 3e299e7

AI Review Summary:

This pull request primarily consists of formatting adjustments, including reordering of imports, minor whitespace changes, and the addition of a newline at the end of a file. There are no logical errors, bugs, or security vulnerabilities introduced by these changes. The code quality remains consistent.

[github-actions]

AI review done up to commit: 36813ac

AI Review Summary:

The changes in this pull request primarily focus on cleaning up comments, clarifying the source of a formula, and explicitly marking unimplemented features.

In src/db/table/operations/helpers/datetime_functions/julian_day.rs, comments related to month/year arithmetic and floating-point precision were removed, which streamlines the code. A significant change was made in the days_in_month function, where the _ => 30 fallback for an invalid month was replaced with _ => unreachable!(). This indicates an expectation that the month parameter passed to this function will always be within the valid range of 1 to 12. Given the month calculation logic in JulianDay::to_gregorian (which uses modulo 12 arithmetic), this assumption holds for that specific call site, making the change a valid correctness improvement.

In src/db/table/operations/helpers/datetime_functions/mod.rs, several detailed comments explaining the behavior of UnixEpoch, JulianDay, Localtime, and Utc modifiers were removed. More importantly, the Localtime and Utc modifiers were changed from a no-op (Ok(jd)) to todo!(), explicitly indicating that these functionalities are not yet implemented. This is a positive change for clarity and development transparency.

Finally, src/db/table/operations/helpers/datetime_functions/modifiers.rs saw the removal of extensive internal design discussions and a redundant impl DateTimeModifier block. This cleanup makes the file more concise and focuses on the final implemented logic.

Overall, the changes improve code readability and maintainability by removing outdated comments and explicitly marking incomplete features. No logical errors, bugs, or security vulnerabilities were identified.

Overall quality assessment: The changes are of good quality, primarily focusing on code cleanup and clarity.
Patterns or recurring issues: No recurring issues were observed. The changes consistently improve the code's clarity and correctness.