fix: normalize empty tool_call arguments to "{}" before serialization#1764
Open
Haroldhhhh wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix: normalize empty tool_call arguments to "{}" before serialization#1764Haroldhhhh wants to merge 1 commit intoMoonshotAI:mainfrom
Haroldhhhh wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
When a tool has no parameters (e.g. `list_files`), the streaming response
may leave `arguments` as `None` or `""`. On the second LLM call,
`model_dump(exclude_none=True)` either drops the field or keeps the empty
string. OpenAI-compatible proxies that forward to Anthropic then fail to
convert it into the required `tool_use.input` dict, causing a 400 error:
`messages.N.content.M.tool_use.input: Input should be a valid dictionary`.
This patch normalizes `arguments` to `"{}"` in `_convert_message` before
serialization, ensuring all proxies receive a parseable JSON object.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a tool has no parameters (e.g.
list_fileswith empty params model), the streaming response may leaveToolCall.function.argumentsasNoneor"". On the next LLM call,model_dump(exclude_none=True)either drops theargumentsfield entirely or keeps the empty string.OpenAI-compatible proxies that forward to Anthropic then fail to convert it into the required
tool_use.inputdict, causing a 400 error:This patch normalizes
argumentsto"{}"in_convert_messagebefore serialization, ensuring all proxies receive a parseable JSON object.Reproduction
OpenAILegacyprovider with an OpenAI-compatible proxy that forwards to Anthropic (e.g.openai-proxy.org)Changes
packages/kosong/src/kosong/contrib/chat_provider/openai_legacy.py: Added normalization of emptyargumentsto"{}"in_convert_messageaftermodel_copy