Skip to content

refactor(toolset): always load MCP tools in background#2356

Open
jiang1997 wants to merge 1 commit into
MoonshotAI:mainfrom
jiang1997:remove-in-background-param
Open

refactor(toolset): always load MCP tools in background#2356
jiang1997 wants to merge 1 commit into
MoonshotAI:mainfrom
jiang1997:remove-in-background-param

Conversation

@jiang1997
Copy link
Copy Markdown

@jiang1997 jiang1997 commented May 23, 2026

Description

  • Resolve the existing TODO to remove in_background from KimiToolset.load_mcp_tools()
  • Make MCP server connection work always run in the background
  • Update callers, tests, and changelog entries for the background-only MCP loading flow

await load_mcp_tools() now means MCP loading has been scheduled. Callers that need to observe connection failures should await wait_for_mcp_tools().

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked the related issue, if any.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run make gen-changelog to update the changelog.
  • I have run make gen-docs to update the user documentation.

Open in Devin Review

Remove the now-redundant in_background option and update callers/tests for the background-only MCP loading flow.
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant