refactor(toolset): always load MCP tools in background#2356
Open
jiang1997 wants to merge 1 commit into
Open
Conversation
Remove the now-redundant in_background option and update callers/tests for the background-only MCP loading flow.
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in_backgroundfromKimiToolset.load_mcp_tools()await load_mcp_tools()now means MCP loading has been scheduled. Callers that need to observe connection failures should awaitwait_for_mcp_tools().Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.