Skip to content

[codex] docs: clarify hooks notification example#2361

Draft
Randy-sin wants to merge 1 commit into
MoonshotAI:mainfrom
Randy-sin:codex/kimi-hooks-docs
Draft

[codex] docs: clarify hooks notification example#2361
Randy-sin wants to merge 1 commit into
MoonshotAI:mainfrom
Randy-sin:codex/kimi-hooks-docs

Conversation

@Randy-sin
Copy link
Copy Markdown

@Randy-sin Randy-sin commented May 24, 2026

Summary

  • Replace the non-functional Notification hook example that used permission_prompt
  • Document that Notification matchers use notification types, not sink names
  • Clarify that approval requests are not currently emitted as Notification hook events

Why

The documented matcher = "permission_prompt" example never fires because approval requests are handled through the approval runtime and wire request path, not through the notification manager.

This is a draft because #2335 already covers the core fix for #2330. The extra bit here is the explicit approval-request clarification and the use-case wording update.

Validation

  • Parsed both updated TOML snippets with tomllib
  • Ran bun run build in docs/

@Randy-sin Randy-sin changed the title [codex] docs: fix hooks notification example [codex] docs: clarify hooks notification example May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant