-
Notifications
You must be signed in to change notification settings - Fork 0
Add: SamAccountType #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: SamAccountType #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces automatic handling of the sAMAccountType attribute for core Active Directory entities (user, group, computer). The changes ensure that this attribute is automatically set during entity creation and backfilled for existing entities.
Changes:
- Added
SamAccountTypeenum with standard Active Directory values - Implemented automatic
sAMAccountTypeattribute assignment in add requests for users, groups, and computers - Created database migration to add
sAMAccountTypeto existing entities - Updated test data and added test coverage for the new functionality
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/enums.py | Defines new SamAccountType enum with AD account type constants |
| app/ldap_protocol/ldap_requests/add.py | Adds logic to automatically set sAMAccountType during entity creation |
| app/ldap_protocol/utils/queries.py | Updates group creation to use enum instead of hardcoded value |
| app/ldap_protocol/auth/use_cases.py | Updates user creation to include sAMAccountType attribute |
| app/constants.py | Replaces hardcoded values with enum references in setup data |
| tests/constants.py | Updates test fixtures to use enum values |
| tests/test_api/test_main/test_router/test_add.py | Adds test to verify automatic sAMAccountType assignment |
| app/alembic/versions/f4e6cd18a01d_add_samaccounttype.py | Migration to backfill sAMAccountType for existing entities |
| interface | Subproject commit update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e references throughout the codebase
Uh oh!
There was an error while loading. Please reload this page.