Add devcontainer and migrate to uv#568
Open
edmundmiller wants to merge 5 commits intoMultiQC:mainfrom
Open
Conversation
edmundmiller
commented
Jun 10, 2025
edmundmiller
commented
- Add development container configuration for MegaQC
- build: Migrate to uv
- build: Update pyyaml to 6.0
- build: Add NODE_OPTIONS for legacy OpenSSL support in webpack scripts
- build: Lock down versions for megaqc initdb
- Introduced devcontainer.json for VS Code setup with Node.js, PostgreSQL, and essential features. - Created docker-compose.yml to define app and PostgreSQL services. - Added Dockerfile to set up the development environment with Python, Node.js, and necessary dependencies. - Included README.md for guidance on using the development container and setup instructions. - Implemented setup.sh script for environment initialization and dependency installation using uv.
- Added `importlib_metadata` as a dependency for Python versions < 3.8. - Downgraded `flask-marshmallow` version to 0.14.0 in `uv.lock`. - Updated version retrieval in `megaqc` package to use `importlib.metadata` with a fallback for older Python versions.
Collaborator
|
Not opposed to any of these changes, but the build will probably be tricky to get working, and I don't have much time to look at it. With the dev container it would be great if you could find a way to re-use some of the dependency logic from the production container. Is an install script a good idea? Or just image inheritance? You also seem to install poetry in the container which shouldn't be used any longer.
Not sure what you mean here. The dev dependency versions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.