Selector updates: holes and existence of TrackState at caloface#17
Merged
madbaron merged 9 commits intoMuonColliderSoft:masterfrom Nov 27, 2024
Merged
Selector updates: holes and existence of TrackState at caloface#17madbaron merged 9 commits intoMuonColliderSoft:masterfrom
madbaron merged 9 commits intoMuonColliderSoft:masterfrom
Conversation
tmadlener
reviewed
Nov 27, 2024
tmadlener
left a comment
tmadlener
left a comment
There was a problem hiding this comment.
For me this can also go in as it is now, but I have one potential improvement and some nitpicking below.
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
tmadlener
reviewed
Nov 27, 2024
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
Author
|
Ok now the package actually compiles (we'll have to clean up the tests..) |
|
I have opened #20 that backports iLCSoft#71 that should fix all the noise that we currently see in the CI workflows. |
tmadlener
approved these changes
Nov 27, 2024
Author
|
GGWP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES