This repository was archived by the owner on Mar 9, 2026. It is now read-only.
Add unit test suite for k4ActsTracking core components#13
Closed
Add unit test suite for k4ActsTracking core components#13
Conversation
It's weird that this didn't pull with the rest of the changes ...
Necessary due to acts-project/acts#3975
This only makes things build with v32 and v43, there are certainly versions in between where different changes would be necessary. (Potentially incomplete) list of related ACTS PRs: - acts-project/acts#3337 - acts-project/acts#4005
Fix Geo Mapping
Removed ROOT, EDM4hep, and Gaudi from the list of acts.
- Modified ACTSAlgBase to update geometry configuration - Added buildsub/, installsub/, and setup.sh to gitignore
Update to TGeoDescFile JSONs
Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
… documentation Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
…or Gaudi interface spelling Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
…e raw pointers with smart pointers Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
Co-authored-by: madbaron <7315158+madbaron@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement test suite for k4ActsTracking package
Add unit test suite for k4ActsTracking core components
Nov 6, 2025
|
Closing this since it has quite a few conflicts and if we should have something like this in the upstream. Additionally, we usually use Catch2 as a testing framework in Key4hep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Point 1 (Unit Tests) from the test suite proposal: establish Google Test infrastructure and validate ActsGaudiLogger, helper functions, and geometry context operations.
Changes
Test Infrastructure
test/unit/CMakeLists.txt)TestMocks.h: MockMessageSvc for IMessageSvc interface testingTests Implemented
ActsGaudiLogger (11 tests, ~80% coverage)
Helper Functions (14 tests)
Geometry Context (10 tests)
Documentation
test/README.md(246 lines): Test structure, coverage summary, running instructionstest/unit/TESTING.md(329 lines): Test patterns, mock usage, debugging guide, coverage goalsExample Usage
Metrics
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.